Skip to content

CLN:Typing in pandas/core/dtypes/ #29606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2019
Merged

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Nov 13, 2019

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@gfyoung gfyoung added the Typing type annotations, mypy/pyright type checking label Nov 14, 2019
MomIsBestFriend and others added 2 commits November 14, 2019 13:51
Last tests failed because it couldn't reach an URL
@jreback jreback added this to the 1.0 milestone Nov 14, 2019
@jreback
Copy link
Contributor

jreback commented Nov 14, 2019

lgtm.

@ShaharNaveh ShaharNaveh marked this pull request as ready for review November 14, 2019 18:41
@jreback jreback merged commit 7ba0e02 into pandas-dev:master Nov 15, 2019
@jreback
Copy link
Contributor

jreback commented Nov 15, 2019

thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the CLN-dtype branch November 16, 2019 14:48
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants