Skip to content

CLN: Remove references to user branch (follow up) #29603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2019
Merged

CLN: Remove references to user branch (follow up) #29603

merged 1 commit into from
Nov 14, 2019

Conversation

alimcmaster1
Copy link
Member

Follow ups from
#29513
and
#25427

(needed for network tests)

  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@jbrockmendel
Copy link
Member

LGTM

@jorisvandenbossche
Copy link
Member

@alimcmaster1 general comment: can you give this PR a title that is somewhat clearer?

@alimcmaster1 alimcmaster1 changed the title Remove ref to branch CLN: Remove references to user branch (follow up) Nov 14, 2019
@alimcmaster1
Copy link
Member Author

@alimcmaster1 general comment: can you give this PR a title that is somewhat clearer?

Yes sorry - agree

@jreback jreback added this to the 1.0 milestone Nov 14, 2019
@jreback jreback merged commit 8a7accd into pandas-dev:master Nov 14, 2019
@jreback
Copy link
Contributor

jreback commented Nov 14, 2019

thanks!

@alimcmaster1 would you mind trying to fix this build: https://travis-ci.org/pandas-dev/pandas/jobs/611742966 (its the allowed failure build); i think it just needs a new reference for an html file. I think we have an issue about this somewhere.

@jorisvandenbossche
Copy link
Member

@alimcmaster1 thanks! Much better ;), that always helps when skimming the prs/issues

@alimcmaster1
Copy link
Member Author

Thanks both! Yes @jreback ill take a look this eve

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@alimcmaster1 alimcmaster1 deleted the mcmali-followup2 branch December 25, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants