CLN: follow-ups #29600
Merged
CLN: follow-ups #29600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/reshape/merge.py
Outdated
| _right = _validate_operand(right) | ||
| self.left = self.orig_left = _validate_operand(_left) # type: "DataFrame" | ||
| self.right = self.orig_right = _validate_operand(_right) # type: "DataFrame" | ||
| _left: "DataFrame" = _validate_operand(left) |
There was a problem hiding this comment.
since _validate_operand is typed (with a return type), the variable annotation is redundant
There was a problem hiding this comment.
we dont want it just for the reader?
There was a problem hiding this comment.
i don't think so. doing this sort of thing could loosen type checking, say if for instance _validate_operand returned a subclass of DataFrame this would pass mypy and the variable would no longer have the type of the subclass
import pandas as pd
class MyDataFrame(pd.DataFrame):
pass
def some_function() -> MyDataFrame:
return MyDataFrame()
loose: pd.DataFrame = some_function()
reveal_type(loose)
tight = some_function()
reveal_type(tight)$ mypy test.py
test.py:13: note: Revealed type is 'pandas.core.frame.DataFrame'
test.py:15: note: Revealed type is 'test.MyDataFrame'
There was a problem hiding this comment.
got it, thanks. will update
jreback
approved these changes
Nov 13, 2019
|
thanks @jbrockmendel |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes requested followups for reshape.merge cc @simonjayhawkins