CLN: no longer need to catch AttributeError, IndexError #29591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| except (ValueError, KeyError, AttributeError, IndexError): | ||
| # TODO: IndexError can be removed here following GH#29106 | ||
| # TODO: AttributeError is caused by _index_data hijinx in | ||
| # libreduction, can be removed after GH#29160 |
There was a problem hiding this comment.
Why can this AttributeError now be removed? (the mentioned PR wasn't merged)
It's solved in a different way?
There was a problem hiding this comment.
This was fixed as a side-effect in #29548. It turned out SeriesGrouper was incorrectly failing to update _index_data, only SeriesBinGrouper was doing it correctly.
There was a problem hiding this comment.
Ah, so it was the _data -> _index_data change there. I see!
jreback
approved these changes
Nov 13, 2019
|
thanks |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jreback @WillAyd
As of today, we don't call
agg_seriesunlessngroups > 0, which has the side-benefit that we don't call unlesslen(self.bins) > 0, which means we no longer risk hitting anIndexErrorin libreduction L262.No longer needing to catch AttributeError is [mumble mumble...] I'll figure out what past-me was thinking after a good night's sleep.