BUG: Fix DatetimeIndex.strftime with NaT present #29583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschendel
added
Bug
Datetime
jschendel
commented
Nov 13, 2019
| @@ -473,7 +473,15 @@ def test_strftime(self, datetime_index): | |||
| arr = DatetimeArray(datetime_index) | |||
|
|
|||
| result = arr.strftime("%Y %b") | |||
| expected = np.array(datetime_index.strftime("%Y %b")) | |||
| expected = np.array([ts.strftime("%Y %b") for ts in arr], dtype=object) | |||
There was a problem hiding this comment.
This change isn't directly related to the PR but something I noticed along the way. I don't think the previous version is completely valid: DatetimeIndex delegates to DatetimeArray for strftime so it was basically testing against itself.
| @@ -679,7 +687,15 @@ def test_strftime(self, period_index): | |||
| arr = PeriodArray(period_index) | |||
|
|
|||
| result = arr.strftime("%Y") | |||
| expected = np.array(period_index.strftime("%Y")) | |||
| expected = np.array([per.strftime("%Y") for per in arr], dtype=object) | |||
There was a problem hiding this comment.
Same thing as my other comment about this pattern for DatetimeArray.
|
|
||
| def test_strftime_nat(self): | ||
| # GH 29578 | ||
| arr = PeriodArray(PeriodIndex(["2019-01-01", pd.NaT], dtype="period[D]")) |
There was a problem hiding this comment.
This is working fine for PeriodArray and PeriodIndex on master; added this test since I didn't see an existing one for this behavior.
mroeschke
reviewed
Nov 13, 2019
|
thanks @jschendel |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff