Skip to content

CLN: F-string formatting in pandas/tests/indexes/*.py (#29547) #29579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2019

Conversation

yashukla
Copy link
Contributor

@yashukla yashukla commented Nov 12, 2019

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@yashukla yashukla closed this Nov 12, 2019
@yashukla yashukla reopened this Nov 13, 2019
@yashukla
Copy link
Contributor Author

I'm a little unsure how to interpret the results of the checks - since code_checks.sh exits with an error at a line where isort is called, it seems like it would point to an issue with importing. However, I haven't changed any import statements, and I checked that all the pytests were consistent with before I changed anything, so I'm not sure what the issue is.

@alimcmaster1
Copy link
Member

Hi @yashukla the issue is related to black opposed to isort see:

black, version 19.3b0
Checking black formatting
would reformat /home/vsts/work/1/s/pandas/tests/indexes/test_common.py

can you run black pandas on the changes?

@alimcmaster1
Copy link
Member

alimcmaster1 commented Nov 13, 2019

Also please could you reference the issue:

#29547

thanks!

@yashukla yashukla changed the title CLN: F-string formatting in pandas/tests/indexes/*.py (#29527) CLN: F-string formatting in pandas/tests/indexes/*.py (#29547) Nov 13, 2019
Style changes as per "black pandas".
@yashukla
Copy link
Contributor Author

@alimcmaster1 Oh, I wasn't using black correctly. Thanks so much! Correct issue referenced, formatting fixed, and code now passes black pandas and git diff upstream/master -u -- "*.py" | flake8 --diff, along with checks; anything else that needs to be done?

@jreback jreback added this to the 1.0 milestone Nov 14, 2019
@jreback jreback added Code Style Code style, linting, code_checks and removed Clean labels Nov 14, 2019
@jreback jreback merged commit d1173de into pandas-dev:master Nov 14, 2019
@jreback
Copy link
Contributor

jreback commented Nov 14, 2019

thanks @yashukla

@yashukla yashukla deleted the fstring-tests-indexes branch November 15, 2019 01:34
@ShaharNaveh ShaharNaveh mentioned this pull request Nov 16, 2019
5 tasks
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants