[BUG] Validate dtype when Int64Index, UInt64Index, or Float64Index are cons… #29545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschendel
reviewed
Nov 11, 2019
jschendel
added
Constructors
…dtype to be passed to float64index, match valueerror message
|
Done, but I don't think it's right yet, need to understand what goes on in test_coercion (shouldn't be necessary to allow Float64 index with integer dtype?) UPDATE: fixed |
…ad remove dtype from call to Float64Index in the constructor of Index
|
@jschendel thanks for your review :) I've updated my PR as per your suggestions |
MarcoGorelli
changed the title
jreback
requested changes
Nov 12, 2019
jschendel
reviewed
Nov 13, 2019
|
Thanks for your reviews, @jreback and @jschendel , really appreciate it. Have updated the PR accordingly. |
jschendel
reviewed
Nov 16, 2019
|
@jschendel sure, done! |
6 tasks
jschendel
approved these changes
Nov 18, 2019
|
Can you merge master to resolve the conflict in the whatsnew? |
|
Done - thanks for the approval! |
jreback
approved these changes
Nov 18, 2019
|
thanks @MarcoGorelli |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tructed
dtypeparameter #29539black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff