Skip to content

Fixed more SS03 errors #29540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Fixed more SS03 errors #29540

merged 1 commit into from
Nov 11, 2019

Conversation

SebStrug
Copy link
Contributor

@SebStrug SebStrug commented Nov 11, 2019

Fixed SS03 errors in the docstrings for pandas.tseries.frequencies.to_offset; pandas.Int64Index; pandas.UInt64Index; pandas.Float64Index; pandas.IntervalIndex; pandas.plotting.plot_params; pandas.io.formats.style.Styler.loader.

This is part of the docstring errors in #27977.

@jreback jreback added the Docs label Nov 11, 2019
@jreback jreback added this to the 1.0 milestone Nov 11, 2019
@jreback jreback merged commit 1a3e0bf into pandas-dev:master Nov 11, 2019
@jreback
Copy link
Contributor

jreback commented Nov 11, 2019

thanks @SebStrug
does this close all of #29315 ?

keechongtan added a commit to keechongtan/pandas that referenced this pull request Nov 11, 2019
…ndexing-1row-df

* upstream/master: (109 commits)
  stronger typing in libreduction (pandas-dev#29502)
  API: rename labels to codes (pandas-dev#29509)
  CLN: remove unnecessary type checks (pandas-dev#29517)
  implement _BaseGrouper (pandas-dev#29520)
  CLN: F-string formatting in pandas/_libs/*.pyx (pandas-dev#29527)
  Fixed more SS03 errors (pandas-dev#29540)
  consolidate dim checks (pandas-dev#29536)
  REF: separate out _get_cython_func_and_vals (pandas-dev#29537)
  remove unnecessary exception (pandas-dev#29538)
  TST:Add test to check single category col returns series with single row slice (pandas-dev#29521)
  Make color validation more forgiving (pandas-dev#29122)
  DOC: update bottleneck repo and documentation urls (pandas-dev#29516)
  TST: add test for df construction from dict with tuples (pandas-dev#29497)
  add test for pd.melt dtypes preservation (pandas-dev#29510)
  updated DataFrame.equals docstring (pandas-dev#29496)
  Resolved merge conflicts (pandas-dev#29506)
  DOC: Improved pandas/compact/__init__.py (pandas-dev#29507)
  DOC: Update performance comparison section of io docs (pandas-dev#28890)
  TST: add test for df.where() with category dtype (pandas-dev#29454)
  DOC: Fix docs on merging categoricals. (pandas-dev#28185)
  ...
@SebStrug SebStrug deleted the SS03-issues-2 branch November 12, 2019 08:26
@SebStrug
Copy link
Contributor Author

@jreback
Two still remain:

  • pandas.Timestamp.isoweekday: Summary does not end with a period
  • pandas.Timestamp.weekday: Summary does not end with a period
    I couldn't find these in the codebase.

More SS03 errors exist for pandas.tseries.offsets but these are false-positives according to @datapythonista. I haven't investigated this, but could open an issue after I've looked into it.

@datapythonista
Copy link
Member

We had some cases where the validation script was validating a Python function we were wrapping, and not our function. That's probably the case for isoweekday and weekday. I think the new version of the script in numpydoc should fix that problem, so probably better to forget about them for now, and when we use the new version of the script, we'll see what's pending.

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants