TST: add tests for Series/DF logical operations nan propagation #29531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Nov 10, 2019
pandas/tests/frame/test_operators.py
Outdated
| @@ -218,6 +218,20 @@ def test_logical_with_nas(self): | |||
| expected = Series([True, True]) | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
| @pytest.mark.parametrize( | |||
| "A, B, C", | |||
There was a problem hiding this comment.
Can you name these "left, right, expected"?
There was a problem hiding this comment.
Thanks, @mroeschke - done.
mroeschke
added
Numeric Operations
ganevgv
force-pushed
the
tests/series_df_logical_nan_consistency
branch
from
9f4a29d to
ad6350a
Compare
mroeschke
approved these changes
Nov 11, 2019
jreback
requested changes
Nov 11, 2019
pandas/tests/frame/test_operators.py
Outdated
| ([True, False, True], [True, False, np.nan], [True, False, True]), | ||
| ], | ||
| ) | ||
| def test_logical_operators_nans(self, left, right, expected): |
There was a problem hiding this comment.
can you add tests for and as well
There was a problem hiding this comment.
Thanks for the feedback, @jreback - done.
jreback
approved these changes
Nov 12, 2019
|
thanks @ganevgv |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff