Skip to content

TST: Add tests for MultiIndex columns cases in aggregate relabelling #29504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 13, 2019

Conversation

charlesdong1991
Copy link
Member

@charlesdong1991 charlesdong1991 commented Nov 9, 2019

@charlesdong1991
Copy link
Member Author

the error isn't related to the change in this PR

@gfyoung gfyoung added MultiIndex Testing pandas testing functions or related to the test suite labels Nov 9, 2019
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test content looks good!

However, let's write them using pytest idiom instead of appending to our existing OOP.

@gfyoung gfyoung added this to the 1.0 milestone Nov 9, 2019
@charlesdong1991
Copy link
Member Author

charlesdong1991 commented Nov 9, 2019

many thanks for your review! @gfyoung
changed!

tests still fail, but i don't think it is relevant to the change in this PR. 🤔

@gfyoung
Copy link
Member

gfyoung commented Nov 9, 2019

@charlesdong1991 : Can you try rebasing OR merging with master and see what happens?

@charlesdong1991
Copy link
Member Author

yeah, it works, probably a flaky test error, I also saw the same error in other PRs. @gfyoung

@jreback jreback merged commit cd04be2 into pandas-dev:master Nov 13, 2019
@jreback
Copy link
Contributor

jreback commented Nov 13, 2019

thanks @charlesdong1991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MultiIndex Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DIfferent result between master and from latest pandas version
4 participants