CLN: annotations in core.dtypes #29503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @jbrockmendel. f-string suggestion and minor query otherwise lgtm.
| @@ -233,16 +235,19 @@ def construct_from_string(cls, string: str): | |||
| ... "'{}'".format(cls.__name__, string)) | |||
| """ | |||
| if not isinstance(string, str): | |||
| raise TypeError("Expects a string, got {}".format(type(string))) | |||
| raise TypeError("Expects a string, got {typ}".format(typ=type(string))) | |||
There was a problem hiding this comment.
if changing .format could now use f-strings?
There was a problem hiding this comment.
oh golly, im still tracking down %-based usage
There was a problem hiding this comment.
I've had a go at upgrading some of our % usage - hopefully there isn't too much more!
https://github.com/pandas-dev/pandas/pull/29518/files
| if string != cls.name: | ||
| raise TypeError( | ||
| "Cannot construct a '{}' from '{}'".format(cls.__name__, string) | ||
| "Cannot construct a '{cls}' from '{string}'".format( |
| if self.categories is None: | ||
| data = "None, " | ||
| else: | ||
| data = self.categories._format_data(name=self.__class__.__name__) | ||
| return tpl.format(data, self._ordered) | ||
| return tpl.format(data=data, ordered=self._ordered) |
|
can you rebase |
|
rebased+green |
|
thanks |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some docstring cleanup.