Update MultiIndex checks #29494
Merged
Update MultiIndex checks #29494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Nov 9, 2019
| @@ -644,7 +644,7 @@ def compute_reduction(arr, f, axis=0, dummy=None, labels=None): | |||
|
|
|||
| if labels is not None: | |||
| # Caller is responsible for ensuring we don't have MultiIndex | |||
| assert not labels._has_complex_internals | |||
| assert labels.nlevels == 1 | |||
There was a problem hiding this comment.
Any reason not to do an isinstance check here? Not a strong blocker usage is mixed; might be nice to settle on one way of doing this
There was a problem hiding this comment.
because we're in cython and dont want to import non-cython
WillAyd
approved these changes
Nov 9, 2019
|
can we completely remove _has_complex_internals? also IIRC there is an open PR about removing it (should close). |
I pushed a rebase on to that this morning. After this I'll probably have to rebase it again and thatll remove _has_complex_internals entirely. |
|
lgtm. merge master once again as I think we merged something related to this in last 4 hours. |
|
rebased+green |
|
thxs |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @WillAyd I'm holding off on most non-trivial groupby stuff, LMK if this is a problem.