CLN: simplify _shallow_copy #29474
Merged
CLN: simplify _shallow_copy #29474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is |
|
huh, looks like it isnt. any strong opinion on where it would be moved? |
|
Maybe merge into WindowMixin. If it’s not actually used for GroupBy I don’t even think we need to keep the GroupByMixin name as that would be rather misleading
…Sent from my iPhone
On Nov 7, 2019, at 5:14 PM, jbrockmendel ***@***.***> wrote:
huh, looks like it isnt. any strong opinion on where it would be moved?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
let me look I made these for consistency between group by and window ops |
For now at least I'm leaning towards keeping it where it is. it would need to go into some shared-by-resample/window location, which describes a lot of groupby code anyway. |
jreback
reviewed
Nov 8, 2019
| @@ -26,7 +26,23 @@ | |||
| """ | |||
|
|
|||
|
|
|||
| class _GroupByMixin(GroupByMixin): | |||
| def _dispatch(name: str, *args, **kwargs): | |||
There was a problem hiding this comment.
eventually add a full doc-string if we end up using this
|
thxs |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class hierarchy of in/around groupby is really tough, this simplifies it a little bit