Skip to content

CLN: remove is_datetimelike #29452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Conversation

jbrockmendel
Copy link
Member

AFAICT this is strictly dominated by needs_i8_conversion

@gfyoung gfyoung added Clean Datetime Datetime data dtype labels Nov 7, 2019
@topper-123
Copy link
Contributor

I had a single question, else looks good.

@jreback jreback added this to the 1.0 milestone Nov 7, 2019
@jreback jreback merged commit 7e6d509 into pandas-dev:master Nov 7, 2019
@jreback
Copy link
Contributor

jreback commented Nov 7, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the cln-dtypes branch November 7, 2019 21:56
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Datetime Datetime data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_datetimelike treatment of PeriodDtype inconsistent
4 participants