Pr09 batch 3 #29434
Merged
Pr09 batch 3 #29434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbrockmendel is there a guide somewhere that specifies what each label is used for? Thanks! |
|
i dont understand the question. what labels? |
|
can you merge master & ping on green. |
no guide on the labels, they are hopefully self-explanatory :-> they are just to organize the issues & PRs |
|
like the Docs label is self explanatory but I'm not sure what Clean is for. Is the failing test (probably) due to a missing commit from master? |
|
@jreback all set. |
|
thanks @HughKelley master was failing because of a numpy change; we disabled that build for now. clean is just a generic label for internal cleaning. |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #28602