-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: workaround numpydev bug #29433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
CI: workaround numpydev bug #29433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want this long-term. But there's no easy way to skip this for numpydev, since it errors in setup.
This was referenced Nov 6, 2019
Closed
pending green, lgtm |
5 tasks
jbrockmendel
reviewed
Nov 6, 2019
This reverts commit 52c1f1b.
It's failing in many places now. I suspect numpy will revert this change, but I'm tracking that in numpy/numpy#14800. For now, we'll ignore failures on numpydev. |
gfyoung
approved these changes
Nov 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this @TomAugspurger !
jreback
approved these changes
Nov 6, 2019
trailing whitespace |
TomAugspurger
added a commit
to TomAugspurger/pandas
that referenced
this pull request
Nov 11, 2019
This reverts commit b4adb71.
jbrockmendel
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
Nov 12, 2019
This reverts commit b4adb71.
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
jreback
pushed a commit
that referenced
this pull request
Nov 25, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want this long-term. But there's no easy way
to skip this for numpydev, since it errors in setup.
xref #29432 (keep open till numpydev is fixed)