Skip to content

BUG: Styling user guide points to a wrong nbviewer link #29429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

janpipek
Copy link
Contributor

@janpipek janpipek commented Nov 6, 2019

Just missing the 'user_guide' part => one line change.

  • closes #xxxx (NOT THAT I KNOW)
  • tests added / passed (NO CODE CHANGE)
  • passes black pandas (NO CODE CHANGE)
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff (NO CODE CHANGE)
  • whatsnew entry (NO CHANGE)

Just missing the 'user_guide' part.
Note: No other internal nbviewer links found in the documentation.
@janpipek janpipek changed the title Fix: Styling user guide points to a wrong nbviewer link BUG: Styling user guide points to a wrong nbviewer link Nov 6, 2019
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nbviewer seems to be having issues right now, but this looks good.

Numpydev failure is being fixed elsewhere.

Thanks!

@TomAugspurger TomAugspurger merged commit 391df15 into pandas-dev:master Nov 6, 2019
@TomAugspurger TomAugspurger added this to the 1.0 milestone Nov 6, 2019
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants