removing kendall tests #29401
Merged
removing kendall tests #29401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. So we don't necessarily want to remove these as much as see if moving them somewhere else in the module saves a lot of time running the benchmarks. Do you know how long it took before / after to run this module? |
|
I did run the tests before making the changes, if that's what you mean by before / after. |
|
No not the benchmark timings themselves as those shouldn't change. Just how long it took to run from start to finish |
|
Ah! I am afraid I didn't time them. |
|
Before: 10m24s |
jreback
requested changes
Nov 4, 2019
…rame/series dimensions
|
By halving the dimensions and removing the bottleneck flags, one could get a runtime of about 5m14s. |
…frame/series dimensions
WillAyd
requested changes
Nov 6, 2019
asv_bench/benchmarks/stat_ops.py
Outdated
| @@ -102,7 +102,7 @@ def time_average_old(self, constructor, pct): | |||
| class Correlation: | |||
|
|
|||
| params = [["spearman", "kendall", "pearson"], [True, False]] | |||
| param_names = ["method", "use_bottleneck"] | |||
| param_names = ["method"] | |||
|
|
|||
| def setup(self, method, use_bottleneck): | |||
There was a problem hiding this comment.
Can you remove the parametrization of use_bottleneck here and in other methods? Also can remove the import / USE_BOTTLENECK assignment in setup
WillAyd
requested changes
Nov 7, 2019
|
@deepandas11 this looks close to ready. can you see why the CI is failing and update? |
Sorry for not being able to resolve this sooner. Was a bit swamped. |
|
hmm this looks ok, I think just merge master and good to go. |
WillAyd
approved these changes
Dec 5, 2019
|
Thanks @deepandas11 ! |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #29270
Following is the output after removing "kendall"