REF: implement first_valid_index in core.missing #29400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschendel
reviewed
Nov 4, 2019
| ------- | ||
| int or None | ||
| """ | ||
| assert how in ["first", "last"] |
There was a problem hiding this comment.
I realize this is the existing behavior, but does it make sense to change this to a ValueError instead? That seems more consistent with how we've been validating these types of parameters elsewhere.
|
thanks @jbrockmendel if you'd hit @jschendel suggestion in a followup would be great. |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation here operates on the values (ndarray or EA) instead of on the Series/DataFrame.
This lets us avoid a runtime import of Series, so core.missing joins the Simple Dependencies Club.