-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: GH25495 incorrect dtype when using .loc to set Categorical value for column in 1-row DataFrame #29393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 21 commits into
pandas-dev:master
from
keechongtan:bug/categorical-indexing-1row-df
Jan 27, 2020
Merged
BUG: GH25495 incorrect dtype when using .loc to set Categorical value for column in 1-row DataFrame #29393
Changes from 14 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
712e871
Fix indexing.setitem when type is pd.Categorical
keechongtan a23b3c9
Move categorical casting check further up
keechongtan 550d68d
Move block creation to after we've check for exact match in shape
keechongtan c945ab1
Remove unused whitespace
keechongtan 5d47754
Move test to TestDataFrameIndexingCategorical, add issue number
keechongtan 2dfa594
Move checks to seperate elif
keechongtan 3e847e9
Merge remote-tracking branch 'upstream/master' into bug/categorical-i…
keechongtan 8c5a88e
Update whatsnew entry
keechongtan ca60804
Merge remote-tracking branch 'upstream/master' into bug/categorical-i…
keechongtan b1520b8
Merge branch 'bug/categorical-indexing-1row-df' of github.com:keechon…
keechongtan 2e95853
Move tests to tests/frame/indexing/test_categorical.py
keechongtan 39c95f4
Fix Pep8 Warning
keechongtan 2b71592
Merge remote-tracking branch 'upstream/master' into bug/categorical-i…
keechongtan e5c1420
Merge remote-tracking branch 'upstream/master' into bug/categorical-i…
keechongtan 4257fe8
use is_categorical_dtype(arr_value.dtype), as is_categorical_astype i…
keechongtan 593dda1
Merge remote-tracking branch 'upstream/master' into bug/categorical-i…
keechongtan 5512119
put exact_match as the first condition
keechongtan c5a7f6e
Merge remote-tracking branch 'upstream/master' into bug/categorical-i…
keechongtan 4c339ac
Merge remote-tracking branch 'upstream/master' into bug/categorical-i…
keechongtan 241bd7c
Remove merge conflict comment
keechongtan 41e6ce4
Merge remote-tracking branch 'upstream/master' into bug/categorical-i…
keechongtan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use
is_categorical_dtype(arr_value.dtype)
is_categorical_astype is not necessary here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the changes, and merged master. All tests passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jreback, is the PR good to merge to master?