Skip to content

TST: new test for sort index when Nan in other axis. #29376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

TST: new test for sort index when Nan in other axis. #29376

wants to merge 2 commits into from

Conversation

ainsleyto
Copy link

closes #12261
test added / passed
passes black pandas

@pep8speaks
Copy link

Hello @ainsleyto! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 746:42: E712 comparison to True should be 'if cond is True:' or 'if cond:'

@jreback jreback added MultiIndex Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Nov 2, 2019
@jbrockmendel
Copy link
Member

@ainsleyto needs rebase, also see the linting complaint above

@WillAyd
Copy link
Member

WillAyd commented Dec 17, 2019

@ainsleyto can you fix the conflict and address feedback?

@jreback
Copy link
Contributor

jreback commented Jan 1, 2020

closing as stale, ping if you want to continue

@jreback jreback closed this Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
MultiIndex Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sort_index doesn't sort MultiIndex when .loc[] referred to non-existent label on other axis
5 participants
@ainsleyto @pep8speaks @jbrockmendel @WillAyd @jreback