Deprecate using `xlrd` engine #29375

cruzzoe · 2019-11-02T20:20:11Z

closes Deprecate using xlrd engine in favor of openpyxl #28547
tests added / passed
passes black pandas
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

WillAyd · 2019-11-02T21:51:18Z

Thanks! Does this also warn if just using read_excel?

cruzzoe · 2019-11-02T23:25:40Z

Thanks! Does this also warn if just using read_excel?

Yes - if you call read_excel there are two cases:

io arg is not an instance of ExcelFile --> ExcelFile is then initialized resulting in Future warning if necessary.
io arg is an instance of ExcelFile --> For this to have happened, the future warning would have already been raised when the io object was initialized.

pandas/io/excel/_base.py

pandas/tests/io/excel/test_xlrd.py

pep8speaks · 2019-11-03T09:02:32Z

Hello @cruzzoe! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pandas/tests/io/excel/test_xlrd.py:

Line 54:78: W291 trailing whitespace

Comment last updated at 2020-01-26 16:36:12 UTC

pandas/io/excel/_base.py

pandas/tests/io/excel/test_xlrd.py

WillAyd · 2019-11-19T04:10:30Z

@cruzzoe can you merge master?

cruzzoe · 2019-11-22T08:51:12Z

@cruzzoe can you merge master?

Sorry- not sure what you mean. This is a merge request of my branch to master. Are you asking me to update my branch off the tip of master?

WillAyd · 2019-11-22T16:18:03Z

Yep that's it!

cruzzoe · 2019-11-23T12:04:28Z

@WillAyd - done

WillAyd · 2019-11-23T22:45:06Z

@cruzzoe unfortunately looks like something went awry with merging master - any idea what steps you might have done?

WillAyd · 2019-11-23T22:46:01Z

I think might have not pulled the latest from upstream before merging. Typically would want to do

git fetch upstream
git merge upstream/master
# fix any merge conflicts
git merge --continue
git push origin YOUR_BRANCH

cruzzoe · 2019-11-24T09:17:34Z

I think might have not pulled the latest from upstream before merging. Typically would want to do
git fetch upstream
git merge upstream/master
# fix any merge conflicts
git merge --continue
git push origin YOUR_BRANCH

I originally did:
git fetch upstream
git rebase upstream/master

When comparing my branch against upstream/master I see only my new changes.

I have reset and redone using merge instead of rebase.

WillAyd · 2019-11-29T18:05:10Z

@cruzzoe can you filter out this warning in the tests? I think OK to apply at the module level - right now this generates a lot of warnings in the CI logs so want to clean that up

alimcmaster1 · 2019-12-23T16:06:53Z

@cruzzoe you still interested in working on this?

cruzzoe · 2019-12-23T18:12:24Z

Yes. Sorry for delay. I'll get back to this very shortly!

…

On Mon, 23 Dec 2019, 16:06 alimcmaster1, ***@***.***> wrote: @cruzzoe <https://github.com/cruzzoe> you still interested in working on this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29375?email_source=notifications&email_token=ACXR24QSRVJPWAJFKSB33BLQ2DOZ7A5CNFSM4JIH46F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHRNJJY#issuecomment-568513703>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACXR24WES7JIR2CNL7E7WX3Q2DOZ7ANCNFSM4JIH46FQ> .

cruzzoe · 2019-12-24T18:31:02Z

@cruzzoe can you filter out this warning in the tests? I think OK to apply at the module level - right now this generates a lot of warnings in the CI logs so want to clean that up

Ive implemented what I think is what you are suggesting. Please could you take a look - I believe this will stop warnings in CI now. Also, I looked at CI to confirm my changes are all good, but I see lots of things failing. Are these related to my change?

WillAyd · 2019-12-24T19:34:12Z

Doc failure I think is related:

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=23821&view=logs&jobId=5291ec4e-9543-503b-43ce-895cf0e06ba3&j=5291ec4e-9543-503b-43ce-895cf0e06ba3&t=ba0a2b35-e1f8-54df-fd66-2b9fde6f4b1f&line=55

So need to update block where this is throwing the warning

jreback · 2020-01-01T21:03:46Z

can you merge master; ping when green.

cruzzoe · 2020-01-20T19:54:31Z

can you merge master; ping when green.

all good.

jreback

can you add a note to the deprecation section as well

WillAyd · 2020-02-12T01:05:19Z

Looks like a merge conflict and still some red CI - @cruzzoe can you fix that up?

WillAyd · 2020-03-04T01:25:10Z

@cruzzoe still active? Can you fix up conflicts and get green?

cruzzoe · 2020-03-04T09:17:47Z

Yep. Will aim for tonight. Thanks for reminder.

…

On Wed, 4 Mar 2020, 01:25 William Ayd, ***@***.***> wrote: @cruzzoe <https://github.com/cruzzoe> still active? Can you fix up conflicts and get green? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29375?email_source=notifications&email_token=ACXR24TCBY5YOOKXHXCVOXDRFWUXRA5CNFSM4JIH46F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENV3HKI#issuecomment-594260905>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACXR24UTHOEZKGB6XEDP3ITRFWUXRANCNFSM4JIH46FQ> .

WillAyd · 2020-04-01T23:59:56Z

@cruzzoe ping on this one again - looks like some merge conflicts to fix

alimcmaster1 · 2020-04-14T22:48:25Z

@cruzzoe can you merge master and get fix up the test?

WillAyd · 2020-04-22T03:56:00Z

Nice PR but looks like this has gone stale. @cruzzoe ping if you’d like to pick backup - still very welcome

jreback added Deprecate Functionality to remove in pandas IO Excel read_excel, to_excel labels Nov 2, 2019

WillAyd requested changes Nov 3, 2019

View reviewed changes

pandas/io/excel/_base.py Outdated Show resolved Hide resolved

pandas/tests/io/excel/test_xlrd.py Outdated Show resolved Hide resolved

cruzzoe force-pushed the 28547 branch from 942c56c to c512884 Compare November 3, 2019 09:02

WillAyd requested changes Nov 3, 2019

View reviewed changes

pandas/io/excel/_base.py Outdated Show resolved Hide resolved

pandas/io/excel/_base.py Outdated Show resolved Hide resolved

WillAyd requested changes Nov 3, 2019

View reviewed changes

pandas/io/excel/_base.py Outdated Show resolved Hide resolved

pandas/tests/io/excel/test_xlrd.py Outdated Show resolved Hide resolved

gfyoung reviewed Nov 4, 2019

View reviewed changes

pandas/tests/io/excel/test_xlrd.py Outdated Show resolved Hide resolved

gfyoung reviewed Nov 4, 2019

View reviewed changes

pandas/tests/io/excel/test_xlrd.py Outdated Show resolved Hide resolved

cruzzoe and others added 4 commits November 23, 2019 12:02

Deprecate using xlrd engine

f48de69

Fix pep8

af0a535

Fixes based on review

a6d5825

Fix based on review

c1327c0

Merge remote-tracking branch 'upstream/master' into 28547

e930b2b

cruzzoe force-pushed the 28547 branch from d235284 to e930b2b Compare November 24, 2019 09:15

WillAyd mentioned this pull request Dec 11, 2019

Deprecate xlwt #26552

Closed

cruzzoe added 2 commits December 24, 2019 17:26

Merge remote-tracking branch 'upstream/master' into 28547

01c11e2

Changes to test to prevent warnings in tests

8bc9419

WillAyd mentioned this pull request Jan 9, 2020

Pandas read_excel sometimes using xlrd which has deprecated code in python 3.8.1 #30851

Closed

Merge remote-tracking branch 'upstream/master' into 28547

5eb9a3e

jreback requested changes Jan 20, 2020

View reviewed changes

cruzzoe added 3 commits January 26, 2020 15:23

Merge remote-tracking branch 'upstream/master' into 28547

3b8ea62

Add in deprecation msg for (pandas-dev#28547)

3073f5a

fixup! Add in deprecation msg for (pandas-dev#28547)

a1bb870

WillAyd mentioned this pull request Feb 26, 2020

Better Message for xlrd Dependencies #28546

Closed

WillAyd closed this Apr 22, 2020

roberthdevries mentioned this pull request Jun 27, 2020

DEPR: Deprecate using xlrd engine for read_excel #35029

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate using `xlrd` engine #29375

Deprecate using `xlrd` engine #29375

cruzzoe commented Nov 2, 2019

WillAyd commented Nov 2, 2019

cruzzoe commented Nov 2, 2019

pep8speaks commented Nov 3, 2019 •

edited

Loading

WillAyd commented Nov 19, 2019

cruzzoe commented Nov 22, 2019

WillAyd commented Nov 22, 2019

cruzzoe commented Nov 23, 2019

WillAyd commented Nov 23, 2019

WillAyd commented Nov 23, 2019

cruzzoe commented Nov 24, 2019

WillAyd commented Nov 29, 2019

alimcmaster1 commented Dec 23, 2019

cruzzoe commented Dec 23, 2019 via email

cruzzoe commented Dec 24, 2019

WillAyd commented Dec 24, 2019 •

edited

Loading

jreback commented Jan 1, 2020

cruzzoe commented Jan 20, 2020

jreback left a comment

WillAyd commented Feb 12, 2020

WillAyd commented Mar 4, 2020

cruzzoe commented Mar 4, 2020 via email

WillAyd commented Apr 1, 2020

alimcmaster1 commented Apr 14, 2020

WillAyd commented Apr 22, 2020

Deprecate using xlrd engine #29375

Deprecate using xlrd engine #29375

Conversation

cruzzoe commented Nov 2, 2019

WillAyd commented Nov 2, 2019

cruzzoe commented Nov 2, 2019

pep8speaks commented Nov 3, 2019 • edited Loading

Comment last updated at 2020-01-26 16:36:12 UTC

WillAyd commented Nov 19, 2019

cruzzoe commented Nov 22, 2019

WillAyd commented Nov 22, 2019

cruzzoe commented Nov 23, 2019

WillAyd commented Nov 23, 2019

WillAyd commented Nov 23, 2019

cruzzoe commented Nov 24, 2019

WillAyd commented Nov 29, 2019

alimcmaster1 commented Dec 23, 2019

cruzzoe commented Dec 23, 2019 via email

cruzzoe commented Dec 24, 2019

WillAyd commented Dec 24, 2019 • edited Loading

jreback commented Jan 1, 2020

cruzzoe commented Jan 20, 2020

jreback left a comment

Choose a reason for hiding this comment

WillAyd commented Feb 12, 2020

WillAyd commented Mar 4, 2020

cruzzoe commented Mar 4, 2020 via email

WillAyd commented Apr 1, 2020

alimcmaster1 commented Apr 14, 2020

WillAyd commented Apr 22, 2020

Deprecate using `xlrd` engine #29375

Deprecate using `xlrd` engine #29375

pep8speaks commented Nov 3, 2019 •

edited

Loading

WillAyd commented Dec 24, 2019 •

edited

Loading