Skip to content

GH 16051: DataFrame.replace() overwrites when values are non-numeric #29359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 4, 2019
Merged

GH 16051: DataFrame.replace() overwrites when values are non-numeric #29359

merged 6 commits into from
Nov 4, 2019

Conversation

pv8473h12
Copy link
Contributor

@pv8473h12 pv8473h12 commented Nov 2, 2019 •
edited by simonjayhawkins
Loading

@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Nov 2, 2019
WillAyd
WillAyd requested changes Nov 2, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, but can you add a similar test for DataFrame.replace as well?

@WillAyd WillAyd added this to the 1.0 milestone Nov 2, 2019
@pv8473h12
Copy link
Contributor Author

I have updated it @WillAyd

jreback
jreback approved these changes Nov 2, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. ping on green.

@pv8473h12
Copy link
Contributor Author

All green @jreback

@WillAyd WillAyd merged commit aa0f138 into pandas-dev:master Nov 4, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 4, 2019

Thanks @pv8473h12

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
@pv8473h12
GH 16051: DataFrame.replace() overwrites when values are non-numeric (p…
a9f6839 
…andas-dev#29359)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@pv8473h12 @proost
GH 16051: DataFrame.replace() overwrites when values are non-numeric (p…
88de39b 
…andas-dev#29359)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@pv8473h12 @proost
GH 16051: DataFrame.replace() overwrites when values are non-numeric (p…
147195c 
…andas-dev#29359)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

DataFrame.replace() overwrites when values are non-numeric
4 participants
@pv8473h12 @WillAyd @jreback @simonjayhawkins