Skip to content

TST: Apply method broken for empty integer series with datetime index #29358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 2, 2019

Conversation

okz12
Copy link
Contributor

@okz12 okz12 commented Nov 2, 2019

I added a unit test for an edge case that was failing. Using the apply method on an empty integer series with a datetime index would throw an error.

@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Nov 2, 2019
@alimcmaster1 alimcmaster1 self-requested a review November 2, 2019 18:29
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks very much!

@jreback jreback added this to the 1.0 milestone Nov 2, 2019
@jreback jreback merged commit 11acbf9 into pandas-dev:master Nov 2, 2019
@jreback
Copy link
Contributor

jreback commented Nov 2, 2019

thanks @okz12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply method broken for empty integer series with datetime index
4 participants