TST: Test type issue fix in empty groupby from DataFrame with categorical #29355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
the
Testing
louishuynh
changed the title
jreback
requested changes
Nov 2, 2019
pandas/tests/groupby/test_groupby.py
Outdated
| @@ -1825,6 +1825,18 @@ def test_groupby_empty_list_raises(): | |||
| df.groupby([[]]) | |||
|
|
|||
|
|
|||
| def test_groupby_with_empty_category(): | |||
There was a problem hiding this comment.
can you move this to groupby/test_categorical.py
pandas/tests/groupby/test_groupby.py
Outdated
| # GH-9614 | ||
| df = pd.DataFrame({"id": [None] * 3, "spam": [None] * 3}) | ||
| df["spam"] = df["spam"].astype("category") | ||
| df["spam"] == "spam" # works as expected |
There was a problem hiding this comment.
can you assert this result here
There was a problem hiding this comment.
I've refactored to what I think is more clear & explicit.
Please approve fine or let me know more asserts still needed, thanks!
|
Hello @louishuynh! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-11-12 19:05:15 UTC |
added 4 commits
November 12, 2019 11:04
jbrockmendel
force-pushed
the
test-groupby-on-categorical
branch
from
480f76c to
4b77aaa
Compare
jreback
approved these changes
Nov 13, 2019
|
thanks @louishuynh |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TST: Test type issue fix in empty groupby from DataFrame with categorical
closes #9614