Skip to content

Pv feature2 #29354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 3, 2019
Merged

Pv feature2 #29354

merged 4 commits into from
Nov 3, 2019

Conversation

pv8473h12
Copy link
Contributor

@pv8473h12 pv8473h12 commented Nov 2, 2019 •
edited by simonjayhawkins
Loading

@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Nov 2, 2019
@jreback jreback added this to the 1.0 milestone Nov 2, 2019
@jreback jreback added the Dtype Conversions Unexpected or buggy dtype conversions label Nov 2, 2019
jreback
jreback requested changes Nov 2, 2019
View reviewed changes
pandas/tests/series/test_replace.py Outdated
# BUG: replace int64 dtype with bool coerces to int64

series = pd.Series(ser)
result = series.replace(to_replace, value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to_replace and value are the same for the cases, so don't make these args, just put it in the code

@jreback
Copy link
Contributor

jreback commented Nov 2, 2019

lgtm. ping on green.

@pv8473h12
Copy link
Contributor Author

All green @jreback

@WillAyd WillAyd merged commit 11f1002 into pandas-dev:master Nov 3, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 3, 2019

Thanks @pv8473h12

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
@pv8473h12
Pv feature2 (pandas-dev#29354)
36904b8
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@pv8473h12 @proost
Pv feature2 (pandas-dev#29354)
2fbb809
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@pv8473h12 @proost
Pv feature2 (pandas-dev#29354)
a4caaa9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

BUG: replace int64 dtype with bool coerces to int64
4 participants
@pv8473h12 @jreback @WillAyd @simonjayhawkins