Skip to content

BUG: timezone offset double counted using date_range and DateTimeIndex.append (fixes #2906, #2938) #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2013

Conversation

stephenwlin
Copy link
Contributor

fixes #2906, #2938

@stephenwlin stephenwlin mentioned this pull request Feb 26, 2013
@xdong
Copy link

xdong commented Feb 26, 2013

Does your patch fix a similar bug for concat in 10.1?

In [17]: from pandas import *

In [18]: dates_a = [Timestamp('20130219 13:00', tz='US/Eastern'), Timestamp('20130220 13:00', tz='US/Eastern')]

In [19]: dates_b = [Timestamp('20130222 13:00', tz='US/Eastern'), Timestamp('20130223 13:00', tz='US/Eastern')]

In [20]: a = Series(range(2), dates_a)

In [21]: b = Series(range(2), dates_b)

In [22]: concat([a, b])
Out[22]:
2013-02-19 18:00:00-05:00 0
2013-02-20 18:00:00-05:00 1
2013-02-22 18:00:00-05:00 0
2013-02-23 18:00:00-05:00 1

Note that the index of Out[22] is wrong (time shifted by 5 hours).

@stephenwlin
Copy link
Contributor Author

probably not, this was specific to date range generation...let me take a look

@jreback
Copy link
Contributor

jreback commented Mar 13, 2013

this ok to merge?

@wesm
Copy link
Member

wesm commented Mar 13, 2013

Looks fine to me-- I haven't looked to verify correctness but no tests had to be changed.

@stephenwlin
Copy link
Contributor Author

yeah, it should be good

jreback added a commit that referenced this pull request Mar 13, 2013
BUG: timezone offset double counted using date_range and DateTimeIndex.append (fixes #2906, #2938)
@jreback jreback merged commit fc2d3cb into pandas-dev:master Mar 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

date_range bug?
4 participants