Skip to content

TST: Adding styler applymap multindex & code test [Ref: #25858] #29346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 5, 2019
Merged

TST: Adding styler applymap multindex & code test [Ref: #25858] #29346

merged 4 commits into from
Nov 5, 2019

Conversation

sofiane87
Copy link
Contributor

@sofiane87 sofiane87 commented Nov 2, 2019 •
edited
Loading

@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Nov 2, 2019
@jreback jreback added this to the 1.0 milestone Nov 2, 2019
@jreback jreback added Indexing Related to indexing on series/frames, not to indexes themselves IO HTML read_html, to_html, Styler.apply, Styler.applymap labels Nov 2, 2019
jreback
jreback requested changes Nov 2, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, small comment, ping on green.

pandas/tests/io/formats/test_style.py
@@ -376,6 +376,23 @@ def color_negative_red(val):

(df.style.applymap(color_negative_red, subset=idx[:, idx["b", "d"]]).render())

def test_applymap_subset_multiindex_code(self):
codes = np.array([[0, 0, 1, 1], [0, 1, 0, 1]])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the issue number as a comment and a 1-liner explain

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now done

@gfyoung gfyoung merged commit d569905 into pandas-dev:master Nov 5, 2019
@gfyoung
Copy link
Member

gfyoung commented Nov 5, 2019

Thanks @sofiane87 !

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
@sofiane87
TST: Adding styler applymap multindex & code test [Ref: pandas-dev#25858
e3fe7c6 
] (pandas-dev#29346)

* TST: Adding styler applymap multindex & code test

Closes pandas-devgh-25858
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@sofiane87 @proost
TST: Adding styler applymap multindex & code test [Ref: pandas-dev#25858
196fb65 
] (pandas-dev#29346)

* TST: Adding styler applymap multindex & code test

Closes pandas-devgh-25858
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@sofiane87 @proost
TST: Adding styler applymap multindex & code test [Ref: pandas-dev#25858
f60b2b7 
] (pandas-dev#29346)

* TST: Adding styler applymap multindex & code test

Closes pandas-devgh-25858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

@gfyoung gfyoung gfyoung approved these changes

Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves IO HTML read_html, to_html, Styler.apply, Styler.applymap Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Styler.applymap(subset=...) breaks promise that "any valid indexer to .loc will work." for mult-index
4 participants
@sofiane87 @gfyoung @jreback @simonjayhawkins