TST: Adding to_dict numeric consistency test (#22620) #29338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
the
Testing
jreback
reviewed
Nov 2, 2019
| # Expected Dtypes | ||
| expected = {"a": int, "b": float, "c": str} | ||
| # Extracting dtypes out of to_dict operation | ||
| df_dict = df.to_dict("records")[0] |
There was a problem hiding this comment.
can you compare the entire result, not just the first record
gfyoung
reviewed
Nov 4, 2019
| "b": type(df_dict["b"]), | ||
| "c": type(df_dict["c"]), | ||
| } | ||
| assert result == expected |
There was a problem hiding this comment.
I would check that the result of df.dtypes is correct. That would be simpler than this for-loop.
There was a problem hiding this comment.
the point is to check that the type returned from to_dict are the same as the ones within the dataset. I am not sure how to do that using df.dtypes. @simonjayhawkins recommended that I make the tests as explicit as possible.
|
this is good, thanks @sofiane87 |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff