-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
WEB: Fix extension of about/index #29329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
est271
commented
Nov 1, 2019
- [✓] closes WEB: about/index has the extension wrong #29325
- [✓] whatsnew: the about/index.html file is now about/index.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@est271 did you generate the website locally to see if this page is looking all right?
You can do it by running python pandas_web.py pandas
in the web directory, and starting a server with python -m http.server
from the web/build
directory.
If you want to upload a screenshot of the page, I'll be able to help check whether everything looks ok.
Thanks for the help on this.
@datapythonista |
Thanks, looks perfect now. The extension in the web needs to be html, we convert markdowns to html if they have the right extension. This is ready, will let someone else from the team review and merged. Thanks for the fix! |
lgtm. merge when ready. |
Sorry for the delay @est271 and thanks a lot for your contribution. Hope to see more coming! |
@datapythonista No worries. Glad to help. |