Skip to content

WEB: Fix extension of about/index #29329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

est271
Copy link
Contributor

@est271 est271 commented Nov 1, 2019

@datapythonista datapythonista added the Web pandas website label Nov 2, 2019
@datapythonista datapythonista changed the title revised about/index.html extension to about/index.md WEB: Fix extension of about/index Nov 2, 2019
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@est271 did you generate the website locally to see if this page is looking all right?

You can do it by running python pandas_web.py pandas in the web directory, and starting a server with python -m http.server from the web/build directory.

If you want to upload a screenshot of the page, I'll be able to help check whether everything looks ok.

Thanks for the help on this.

@est271
Copy link
Contributor Author

est271 commented Nov 2, 2019

@datapythonista
Here is a screenshot of the page that was generated locally. I just noticed that the URL shows the .html extension at the end. Should it be .md or is it ok as shown?

Screenshot_index_html

@datapythonista
Copy link
Member

Thanks, looks perfect now. The extension in the web needs to be html, we convert markdowns to html if they have the right extension.

This is ready, will let someone else from the team review and merged.

Thanks for the fix!

@jreback jreback added this to the 1.0 milestone Nov 2, 2019
@jreback
Copy link
Contributor

jreback commented Nov 2, 2019

lgtm. merge when ready.

@datapythonista datapythonista merged commit 165d5ee into pandas-dev:master Nov 4, 2019
@datapythonista
Copy link
Member

Sorry for the delay @est271 and thanks a lot for your contribution. Hope to see more coming!

@est271
Copy link
Contributor Author

est271 commented Nov 4, 2019

@datapythonista No worries. Glad to help.

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web pandas website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WEB: about/index has the extension wrong
3 participants