Implement safe_ea_cast to avoid catching Exception #29293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
reviewed
Oct 31, 2019
gfyoung
added
ExtensionArray
|
I think comments have been addressed. LMK if i missed anything |
gfyoung
reviewed
Oct 31, 2019
gfyoung
reviewed
Oct 31, 2019
gfyoung
reviewed
Nov 1, 2019
Co-Authored-By: gfyoung <[email protected]>
gfyoung
approved these changes
Nov 1, 2019
jreback
reviewed
Nov 2, 2019
| @@ -32,6 +32,29 @@ | |||
| _extension_array_shared_docs = dict() # type: Dict[str, str] | |||
|
|
|||
|
|
|||
| def try_cast_to_ea(cls_or_instance, obj, dtype=None): | |||
|
thanks, small followon request. |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of having
except Exceptionin many places, we have it in one place, with one helpful comment