BLD: fix some build warnings #29271
Merged
BLD: fix some build warnings #29271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Oct 29, 2019
| @@ -235,7 +235,8 @@ cdef class Packer: | |||
| continue | |||
| else: | |||
| raise TypeError("can't serialize {thing!r}".format(thing=o)) | |||
| return ret | |||
| break | |||
There was a problem hiding this comment.
really? cython doesn't understand the else here?
There was a problem hiding this comment.
Its clang giving a "code will never be executed" warning
WillAyd
reviewed
Oct 29, 2019
| @@ -22,54 +22,55 @@ ctypedef fused out_t: | |||
| def diff_2d(ndarray[diff_t, ndim=2] arr, | |||
| ndarray[out_t, ndim=2] out, | |||
| Py_ssize_t periods, int axis): | |||
| cdef: | |||
There was a problem hiding this comment.
I believe all you did was move this and not change conditions below but lmk if I am misreading
There was a problem hiding this comment.
The cdef here got moved up a few lines and the meat of the function got indented with an else: to avoid unreachable-code warnings
|
Looks like travis finished a while ago, not sure why it still shows as yellow here |
|
fixed travis; green |
|
thanks |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.