Skip to content

BLD: ABCSeries mapper maps unmapped categories to "" instead of NaN #29266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

BLD: ABCSeries mapper maps unmapped categories to "" instead of NaN #29266

wants to merge 1 commit into from

Conversation

LiuSeeker
Copy link
Contributor

@WillAyd
Copy link
Member

WillAyd commented Oct 29, 2019

I think this is going to break a lot of things and maybe not the direction we want. Did you see @jorisvandenbossche comment in the original post?

@WillAyd WillAyd added the Categorical Categorical Data Type label Oct 29, 2019
@LiuSeeker
Copy link
Contributor Author

Yeah, just saw it. I'll close this pr and think about another approach to resolve the issue

@LiuSeeker LiuSeeker closed this Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Categorical Categorical Data Type
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.map on category dtype does not respect defaultdict when encountering np.nan values
2 participants
@LiuSeeker @WillAyd