Skip to content

DOC: use new logo in the sphinx theme as well #29259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2019

Conversation

jorisvandenbossche
Copy link
Member

With this change (pydata/pydata-sphinx-theme@84134e0) in the theme, that should work.

However, locally, I am running into the problem that sphinx/html doesn't seem to like the svg logo's .. For local testing I added a converted png which works, but just replacing .png with .svg makes that the html does not include the image (at least in firefox).

cc @datapythonista

@jorisvandenbossche jorisvandenbossche added this to the 1.0 milestone Oct 28, 2019
@jorisvandenbossche
Copy link
Member Author

OK, that issue could be fixed with css in the theme (apparently need to explicitly set the height for the img tag in the navbar to force the scaling)

@datapythonista
Copy link
Member

Are we going to keep the docs independent from the web? My preference is to use the template of the web to build the docs, and I guess this is not needed if we do that.

@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Oct 29, 2019

Well, we have #28580 for that discussion. In my last comment there, I put some examples of other doc sites / websites. Interested to hear your thoughts about that.
Let's continue that discussion there.

I guess this is not needed if we do that.

As long as we use the sphinx theme, this is needed (so since such integration won't happen today, going to merge this to have the new logo on the dev docs short term). But this relative path at least ensures to not duplicate the actual logo source.
But even if we re-use the layouts of the web, I am not fully sure that sphinx can work with layouts/images outside of its directory (eg with this PR, sphinx copies the image to _static in the build directory)

@jorisvandenbossche jorisvandenbossche merged commit 1574956 into pandas-dev:master Oct 29, 2019
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants