Remove TestData in series tests indexing #29220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Clean
Testing
SaturnFromTitan
force-pushed
the
remove-testdata-in-series-tests_indexing
branch
from
0052392 to
ab71d86
Compare
SaturnFromTitan
changed the title
SaturnFromTitan
force-pushed
the
remove-testdata-in-series-tests_indexing
branch
from
ab71d86 to
ed4d980
Compare
|
lgtm. Can you remove the common module altogether now? |
|
As the other series related PRs are merged now - yes! I'll add that another commit for that |
…s/series/indexing/test_alter_index.py
…s/series/indexing/test_boolean.py
…s/series/indexing/test_indexing.py
…s/series/indexing/test_loc.py
…s/series/indexing/test_numeric.py
SaturnFromTitan
force-pushed
the
remove-testdata-in-series-tests_indexing
branch
from
ed4d980 to
ce20213
Compare
|
thanks @SaturnFromTitan very nice! |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #22550
pandas/tests/series/indexing/with more granular fixturesblack pandasgit diff upstream/master -u -- "*.py" | flake8 --diff