Changing logo in README and removing old logo #29215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd slightly prefer to wait until the new site goes up as it would be cooler to release at once, but not blocking if others want to move forward with this |
|
As said, no strong preference, and also thought it'd be cool to change everything together. But I see advantages on moving forward:
Nothing is that important, but that's why I thought of opening this now. CC: @TomAugspurger |
|
+1 in this doing anythig non completely standardized at release time is a no no |
|
Either works for me. Will's points are good, but I may lean slightly towards just updating this now. 1.0 will still be a large enough celebration I think :) The CI failure can likely be ignored. |
|
@WillAyd happy to get this merged, based on previous comments? |
|
Yea totally - merge away if ready |
HawkinsBA
pushed a commit
to HawkinsBA/pandas
that referenced
this pull request
Oct 29, 2019
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if anyone prefers to publish the new logo when we release pandas 1.0 and the new website is life. I don't have a strong preference, but I'd say let's change the logo now if nobody cares, so one thing less to think about. I'll change the twitter logo and tweet about it once this is merged.