Skip to content

CLN: simplify core.algorithms #29199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 25, 2019
Merged

CLN: simplify core.algorithms #29199

merged 3 commits into from
Oct 25, 2019

Conversation

jbrockmendel
Copy link
Member

No description provided.

@gfyoung gfyoung added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Clean labels Oct 24, 2019
WillAyd
WillAyd reviewed Oct 24, 2019
View reviewed changes
pandas/core/algorithms.py
or is_timedelta64_dtype(original)
or is_period_dtype(original)
):
if original.dtype.kind in ["m", "M"]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a silly question but wouldn't the datetimelike arrays pass through the is_extension_array_dtype branch here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the period and dt64tz go through that EA branch above, td64 and dt64-naive go through here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment to that effect. (can also merge this and do that later)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will comment in next pass

@jreback jreback added this to the 1.0 milestone Oct 25, 2019
@jreback jreback merged commit f58b07e into pandas-dev:master Oct 25, 2019
@jreback
Copy link
Contributor

jreback commented Oct 25, 2019

thanks

@jbrockmendel jbrockmendel deleted the algos_cln branch October 25, 2019 17:53
HawkinsBA pushed a commit to HawkinsBA/pandas that referenced this pull request Oct 29, 2019
@jbrockmendel
CLN: simplify core.algorithms (pandas-dev#29199)
adfd4de
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Oct 31, 2019 •
edited
Loading

This seems to have caused a small but consistent performance regression: https://pandas.pydata.org/speed/pandas/#index_object.IntervalIndexMethod.time_intersection?p-param1=1000&commits=f58b07e0 (might be worth investigating)

(to be clear: just reporting here what ASV reports, didn't do any sanity check of the validity of the report)

@jbrockmendel
Copy link
Member Author

I'll take a look, thanks

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
@jbrockmendel
CLN: simplify core.algorithms (pandas-dev#29199)
5c7d08a
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
CLN: simplify core.algorithms (pandas-dev#29199)
4084eb3
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
CLN: simplify core.algorithms (pandas-dev#29199)
588a298
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
@jbrockmendel
CLN: simplify core.algorithms (pandas-dev#29199)
fab8250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd left review comments

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Clean
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jbrockmendel @jreback @jorisvandenbossche @WillAyd @gfyoung