Skip to content

CLN: dont catch Exception in _aggregate_frame #29194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

jbrockmendel
Copy link
Member

@gfyoung gfyoung added Clean Error Reporting Incorrect or improved errors from pandas labels Oct 24, 2019
@jreback jreback added this to the 1.0 milestone Oct 24, 2019
@jreback jreback merged commit de586c1 into pandas-dev:master Oct 24, 2019
@jreback
Copy link
Contributor

jreback commented Oct 24, 2019

thanks

@jbrockmendel jbrockmendel deleted the faster46 branch October 24, 2019 15:40
raise
except Exception:
wrapper = lambda x: func(x, *args, **kwargs)
result[name] = data.apply(wrapper, axis=axis)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this fallback not needed? It was never reached according to the tests? Or is it done elsewhere?

HawkinsBA pushed a commit to HawkinsBA/pandas that referenced this pull request Oct 29, 2019
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants