Skip to content

TST: Test Series integer mod behavior on string #29180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Oct 23, 2019

Closes #24396

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Numeric Operations Arithmetic, Comparison, and Logical operations Series Series data structure labels Oct 23, 2019
@gfyoung gfyoung added this to the 1.0 milestone Oct 23, 2019
@gfyoung gfyoung force-pushed the series-int-mod-string branch from 0a3310b to baa8195 Compare October 23, 2019 09:31
@jreback
Copy link
Contributor

jreback commented Oct 23, 2019

lgtm but cc @jbrockmendel for verification.

@jbrockmendel
Copy link
Member

lgtm

@jbrockmendel
Copy link
Member

could parametrize over Series/Index/DataFrame if you wanted. not a big deal

@WillAyd WillAyd merged commit 0f92514 into pandas-dev:master Oct 23, 2019
@WillAyd
Copy link
Member

WillAyd commented Oct 23, 2019

Thanks @gfyoung

@gfyoung gfyoung deleted the series-int-mod-string branch October 23, 2019 18:40
HawkinsBA pushed a commit to HawkinsBA/pandas that referenced this pull request Oct 29, 2019
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Numeric Operations Arithmetic, Comparison, and Logical operations Series Series data structure Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Series of integers mod behavior
4 participants