Skip to content

Remove TestData in frame tests in multiple files #29172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SaturnFromTitan
Copy link
Contributor

@SaturnFromTitan SaturnFromTitan commented Oct 22, 2019

Part of #22471

This is removing/replacing TestData usage in the following files:

  • test_convert_to.py
  • test_nonunique_indexes.py
  • test_query_eval.py
  • test_replace.py
  • test_repr_info.py

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@WillAyd WillAyd added the Testing pandas testing functions or related to the test suite label Oct 23, 2019
@WillAyd WillAyd added this to the 1.0 milestone Oct 23, 2019
@SaturnFromTitan SaturnFromTitan force-pushed the remove-testdata-in-frame-tests branch from a02ad33 to 15a45b1 Compare October 23, 2019 20:14
@SaturnFromTitan
Copy link
Contributor Author

I took care of all comments and as suggested by jreback I'll create a follow-up PR to resolve the remaining TestData usage in test_query_eval.py.

@WillAyd @jreback Can you please take another look? Thanks!

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Can you merge master and push one more time just to be sure? Travis builds should at least be fixed now

@SaturnFromTitan SaturnFromTitan force-pushed the remove-testdata-in-frame-tests branch 3 times, most recently from ae4c330 to 75fb6b6 Compare October 24, 2019 15:23
@SaturnFromTitan SaturnFromTitan force-pushed the remove-testdata-in-frame-tests branch from 75fb6b6 to b79ef2f Compare October 24, 2019 15:23
@jreback jreback merged commit 343544d into pandas-dev:master Oct 25, 2019
@jreback
Copy link
Contributor

jreback commented Oct 25, 2019

thanks @SaturnFromTitan

HawkinsBA pushed a commit to HawkinsBA/pandas that referenced this pull request Oct 29, 2019
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants