-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Edit MultiIndex.set_levels() docstring to clarify that set_levels() interprets passed values as new components of the .levels attribute (#28294) #29143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
datapythonista
merged 9 commits into
pandas-dev:master
from
hweecat:docfix-multiindex-set_levels
Jan 3, 2020
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b851cfd
edit set_levels docstring
hweecat 94df048
Merge remote-tracking branch 'upstream/master' into docfix-multiindex…
hweecat 11976fc
rebase and resolve merge conflicts
hweecat 0b51bd5
Merge remote-tracking branch 'upstream/master' into docfix-multiindex…
hweecat 6f6d325
Merge remote-tracking branch 'upstream/master' into docfix-multiindex…
hweecat bd07d3a
update set_levels docstrings
hweecat 78be91c
Merge remote-tracking branch 'upstream/master' into docfix-multiindex…
hweecat f29a9b8
update set_levels docstrings for clarity
hweecat 2a97c43
Merge remote-tracking branch 'upstream/master' into docfix-multiindex…
hweecat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wording ("stored though truncated") is a little awkward - not sure I 100% understand what this means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the following wording be clearer in expressing the concept?
"stored in the MultiIndex levels, though the values will be truncated in the MultiIndex output."
Feel free to let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that’s a great edit - care to make that change?