CLN: remove Block._try_coerce_arg #29139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Clean
Internals
|
The test failure here seems related? You might reproduce it locally by elevating warnings to errors with |
jreback
approved these changes
Oct 24, 2019
| @@ -7,7 +7,8 @@ | |||
|
|
|||
| import numpy as np | |||
|
|
|||
| from pandas._libs import NaT, Timestamp, lib, tslib, writers | |||
| from pandas._libs import NaT, lib, tslib, writers | |||
| from pandas._libs.index import convert_scalar | |||
There was a problem hiding this comment.
followup: convert_scalar should be in pandas.core.dtypes.cast (you can just call the cython version), but import / expose from there.
also the cython version is in a very weird place (index.pyx).
|
nice removals, pls create an issue / PR for the follow when you have a chance. |
HawkinsBA
pushed a commit
to HawkinsBA/pandas
that referenced
this pull request
Oct 29, 2019
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made possible by modernizing
libindex.convert_scalar