REF: avoid getattr pattern for rank_1d, rank_2d #29137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Oct 22, 2019
| @@ -455,7 +455,7 @@ def _group_add(complexfloating_t[:, :] out, | |||
| if len(values) != len(labels): | |||
| raise ValueError("len(index) != len(labels)") | |||
|
|
|||
| nobs = np.zeros((len(out), out.shape[1]), dtype=np.int64) | |||
| nobs = np.zeros((<object>out).shape, dtype=np.int64) | |||
There was a problem hiding this comment.
What does the object cast buy us here?
There was a problem hiding this comment.
https://groups.google.com/forum/#!topic/cython-users/xheRGGOiuYw
For reasons unknown, out.shape is evaluated as an 8-tuple instead of 2-tuple, and this call raises at runtime without the <object> cast. That's the reason why the status quo doesn't use out.shape directly on L458.
There was a problem hiding this comment.
Pretty interesting...and cast to object here doesn't trigger any underlying functions? Not sure if it just changes the type of pointer Cython uses or if it actually changes the memview
|
thanks @jbrockmendel yes nice cleanup |
HawkinsBA
pushed a commit
to HawkinsBA/pandas
that referenced
this pull request
Oct 29, 2019
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix incorrectly-typed
nobsin libgroupby