REF: avoid getattr pattern for diff_2d; use fused types #29120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Oct 20, 2019
|
|
||
| for name, c_type, dest_type, in dtypes: | ||
| yield name, c_type, dest_type | ||
| ctypedef fused diff_t: |
There was a problem hiding this comment.
isn’t this numeric? can we consolidate these later
jbrockmendel
changed the title
jreback
reviewed
Oct 22, 2019
|
|
||
| # Disable for unsupported dtype combinations, | ||
| # see https://github.com/cython/cython/issues/2646 | ||
| if out_t is float32_t: |
There was a problem hiding this comment.
assume this a later followup
|
thanks |
jbrockmendel
commented
Oct 23, 2019
| raise NotImplementedError | ||
| else: | ||
| if (diff_t is float32_t or diff_t is int8_t or diff_t is int16_t): | ||
| raise NotImplementedError |
There was a problem hiding this comment.
@WillAyd you may have noticed a bunch of build warnings about unreachable code have started showing up. I'm pretty sure this is the reason. Any thoughts on more graceful ways to get the combination of dtypes we're interested in? (see the GH link on L27)
The same dtype-combination thing is the only reason why algos_take_helper isn't converted to fused types; it'd be really nice to clear that up
There was a problem hiding this comment.
Don't know off the top of my head - maybe an Enum using the type as a member?
HawkinsBA
pushed a commit
to HawkinsBA/pandas
that referenced
this pull request
Oct 29, 2019
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.