Skip to content

DOC: Add instructions how to activate virtual env under windows with pip #29113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 1, 2019
Merged

DOC: Add instructions how to activate virtual env under windows with pip #29113

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8dcb6f9
DOC: Add instructions how to activate virtual env under windows with pip
gbaychev Oct 19, 2019
d94c5a1
Remove the unneeded whatsnew entry
gbaychev Oct 23, 2019
7aaf270
Refer to the official user guide regarding the activation of virtual env
gbaychev Oct 23, 2019
39f6fa7
Move the Windows doc about venv with pip into a separate code block
gbaychev Oct 24, 2019
e1d3a6d
Additional refinement
Oct 25, 2019
776e542
PR improvements
gbaychev Nov 1, 2019
dc93e56
Extract some windows pip venv comment insturctions into a separate pa…
gbaychev Nov 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions doc/source/development/contributing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,16 @@ You'll need to have at least python3.5 installed on your system.
# Create a virtual environment
# Use an ENV_DIR of your choice. We'll use ~/virtualenvs/pandas-dev
# Any parent directories should already exist
# If you are using Windows and command prompt, replace ~ (the tilde sign)
# with %userprofile%
python3 -m venv ~/virtualenvs/pandas-dev

# Activate the virtualenv
# If you are using Windows, you can find the activation scripts under
# ~\virtualenvs\pandas-dev\scripts
# Please refer to the official user guide at
# https://virtualenv.pypa.io/en/stable/userguide/#activate-script
# about how to activate your virtual environment under Windows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying this @gbaychev.

Don't you think could be clearer to have the windows instructions in a separate block? Feels like there is too much information in this block now. And having two blocks would let users just read the one they care about, and have the information presented in a clearer way.

Feel free to disagree, but I think we can probably do better at communicating this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You guys are very careful and diplomatic, cheers for that :) Yes @datapythonista, you are absolutely correct, I've split the information into two code-blocks, please see 39f6fa7

. ~/virtualenvs/pandas-dev/bin/activate

# Install the build dependencies
Expand Down