Skip to content

BUG: fix TypeError raised in maybe_downcast_numeric #29103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

jbrockmendel
Copy link
Member

Part of the groupby-Exception whittling; cc @WillAyd @jreback

@jreback jreback added Bug Dtype Conversions Unexpected or buggy dtype conversions labels Oct 22, 2019
@jreback jreback added this to the 1.0 milestone Oct 22, 2019
@jreback
Copy link
Contributor

jreback commented Oct 22, 2019

does this affect user facing code?

@jbrockmendel
Copy link
Member Author

does this affect user facing code?

Not really. I've found one other place in groupby code where we can remove except TypeError once this is fixed, but thats about it

@jreback
Copy link
Contributor

jreback commented Oct 23, 2019

this looks reasonable

@jreback jreback merged commit 30362ed into pandas-dev:master Oct 23, 2019
@jbrockmendel jbrockmendel deleted the faster_cast branch October 23, 2019 01:54
HawkinsBA pushed a commit to HawkinsBA/pandas that referenced this pull request Oct 29, 2019
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants