TST: Add regression test for Series index.map failing (#20990) #29093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
added
the
Testing
jreback
requested changes
Oct 19, 2019
WillAyd
requested changes
Oct 22, 2019
|
@WillAyd ping |
WillAyd
requested changes
Nov 6, 2019
| # see GH20990 | ||
| count = 6 | ||
| index = pd.date_range("2018-01-01", periods=count, freq="M", name=name) | ||
| a = pd.Series(np.arange(count), index=index) |
There was a problem hiding this comment.
Can you delete the Series altogether and just use tm.assert_index_equal? I don't think the Series is required at all
There was a problem hiding this comment.
Do you mean to make it look like following?
@pytest.mark.parametrize("name", [None, "name"])
def test_index_map(self, name):
# see GH20990
count = 6
index = pd.date_range("2018-01-01", periods=count, freq="M", name=name).map(lambda x: (x.year, x.month))
expected = pd.MultiIndex.from_product(
((2018,), range(1, 7)), names=[name, name]
)
tm.assert_index_equal(index, expected)
|
pls merge master |
TomAugspurger
approved these changes
Nov 18, 2019
WillAyd
approved these changes
Nov 18, 2019
|
Thanks @Reksbril ! |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff