Skip to content

TST: Add regression test for Series dropping uint datatype (#18311) #29071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2019

Conversation

Reksbril
Copy link
Contributor

@Reksbril Reksbril commented Oct 18, 2019

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Some minor edits

@WillAyd WillAyd added the Testing pandas testing functions or related to the test suite label Oct 18, 2019
@WillAyd WillAyd added this to the 1.0 milestone Oct 18, 2019
@jreback jreback added the Dtype Conversions Unexpected or buggy dtype conversions label Oct 18, 2019
Requested changes were:
- add issue number as a comment
- parametrize test, instead of looping through array
- change type variable to type_
@Reksbril Reksbril requested review from jreback and WillAyd October 19, 2019 14:41
@Reksbril Reksbril requested a review from jreback October 21, 2019 16:12
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @jreback

@jreback jreback merged commit 7b8e22d into pandas-dev:master Oct 22, 2019
@jreback
Copy link
Contributor

jreback commented Oct 22, 2019

thanks @Reksbril

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assignment to uint series drops datatype
3 participants