Skip to content

CLN: Fixing mypy errors in pandas/conftest.py #29046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 25, 2020
Merged

CLN: Fixing mypy errors in pandas/conftest.py #29046

Changes from 3 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
bfc175e
Ignoring some mypy errors related to imports and list inference
angelaambroz Oct 17, 2019
6408388
Adding Dtype
angelaambroz Oct 17, 2019
f4afbb2
Two spaces
angelaambroz Oct 17, 2019
ce2d9b7
MR comments
angelaambroz Oct 18, 2019
96a09ec
MR comments, removing type ignore
angelaambroz Oct 18, 2019
f07b7a0
Type Union etc
angelaambroz Oct 19, 2019
77543f2
Forgot Type
angelaambroz Oct 21, 2019
50dadb2
PR comments
angelaambroz Nov 2, 2019
5bce559
Merge conflict importing Type in _typing
angelaambroz Nov 2, 2019
1856a58
Merge remote-tracking branch 'upstream/master' into issue28926_conftest
angelaambroz Dec 13, 2019
4be05dc
PR comments
angelaambroz Dec 13, 2019
3fbf980
Update pandas/_typing.py
angelaambroz Dec 29, 2019
05bb32b
Merge conflicts
angelaambroz Jan 16, 2020
4b8b565
Fixing import sort order
angelaambroz Jan 16, 2020
a920f28
Merge conflicts
angelaambroz Mar 25, 2020
dd279e9
Linting
angelaambroz Mar 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pandas/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@
from hypothesis import strategies as st
import numpy as np
import pytest
from pytz import FixedOffset, utc
from pytz import FixedOffset, utc # type: ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as #28932 - I think this needs to be fixed upstream in Typeshed. Would you be interested in submitting that there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure - I can give it a shot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Picking this up again - just got the changes merged in typeshed (python/typeshed#3393). I see that there are now some conflicts with master; I can address those and pick this up again in the next couple days.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job and thanks for fixing that upstream! Still not a rush on our end but should make it into the next mypy release. Will be helpful for us in a few places


import pandas.util._test_decorators as td
from pandas._typing import Dtype

import pandas as pd
from pandas import DataFrame
Expand Down Expand Up @@ -481,7 +482,7 @@ def tz_aware_fixture(request):

UNSIGNED_INT_DTYPES = ["uint8", "uint16", "uint32", "uint64"]
UNSIGNED_EA_INT_DTYPES = ["UInt8", "UInt16", "UInt32", "UInt64"]
SIGNED_INT_DTYPES = [int, "int8", "int16", "int32", "int64"]
SIGNED_INT_DTYPES = [int, "int8", "int16", "int32", "int64"] # type: Dtype
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a List[Dtype]

Copy link
Member

@WillAyd WillAyd Oct 17, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Dtype needs to be updated in pandas._typing to include Type[Union[float, int, str, bool]] for when the built-in values get provided - could you make that change as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, sure - thanks for the guidance.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type[Union[float, str, bool]] would be sufficient as int is duck type compatible with float see https://mypy.readthedocs.io/en/latest/duck_type_compatibility.html#duck-type-compatibility

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, both. Just pushed what I think you both meant - let me know. I'm still learning about types! Looks like complex was also duck typed to float.

SIGNED_EA_INT_DTYPES = ["Int8", "Int16", "Int32", "Int64"]
ALL_INT_DTYPES = UNSIGNED_INT_DTYPES + SIGNED_INT_DTYPES
ALL_EA_INT_DTYPES = UNSIGNED_EA_INT_DTYPES + SIGNED_EA_INT_DTYPES
Expand Down