Skip to content

fix is_scalar documentation (#28998) #29004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andreasbuhr
Copy link
Contributor

is_scalar documentation was wrong, see #28998

@moi90
Copy link
Contributor

moi90 commented Oct 15, 2019

I was about to do the same... ^^

@WillAyd WillAyd added the Docs label Oct 15, 2019
@WillAyd WillAyd added this to the 1.0 milestone Oct 15, 2019
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. We are working on a release of 0.25.2 today so this might sit for a bit, but I don't think changes are required unless anyone else disagrees

@TomAugspurger
Copy link
Contributor

@WillAyd no harm in merging to master since this is going in 1.0.

@TomAugspurger TomAugspurger merged commit 8d3fec9 into pandas-dev:master Oct 15, 2019
@TomAugspurger
Copy link
Contributor

Thanks @andreasbuhr!

@andreasbuhr andreasbuhr deleted the fix_is_scalar_documentation branch October 15, 2019 15:25
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation bug in pandas.api.types.is_scalar
4 participants